Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstalling a packge warns "cannot find THE_PACKAGE in uninst-start" #1653

Closed
ppisar opened this issue Apr 17, 2024 · 1 comment · Fixed by #1660
Closed

Reinstalling a packge warns "cannot find THE_PACKAGE in uninst-start" #1653

ppisar opened this issue Apr 17, 2024 · 1 comment · Fixed by #1660
Assignees
@kontura

Comments

@ppisar
Copy link
Contributor

ppisar commented Apr 17, 2024

Using microdnf (compiled from the latest Fedora 40 sources) with libdnf-0.73.1-20240417004923.1.g85432dfd.fc41.x86_64 produces 3 "cannot find" libdnf warnings:

# ~test/fedora/microdnf/microdnf-3.10.0/redhat-linux-build/dnf/microdnf reinstall bashDownloading metadata...

(microdnf:2616): libdnf-WARNING **: 14:37:05.006: Skipping refresh of rpminspect: cannot update repo 'rpminspect': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried; Last error: Status code: 404 for https://download.copr.fedorainfracloud.org/results/dcantrell/rpminspect/fedora-rawhide-$arch/repodata/repomd.xml (IP: 52.222.214.128)
Package                                                                 Repository                 Size
Reinstalling:
 bash-5.2.26-3.fc40.x86_64                                              f41-build                1.9 MB
   replacing bash-5.2.26-3.fc40.x86_64
Transaction Summary:
 Installing:        0 packages
 Reinstalling:      1 packages
 Upgrading:         0 packages
 Obsoleting:        0 packages
 Removing:          0 packages
 Downgrading:       0 packages
Is this ok [y/N]: y
Downloading packages...
Running transaction test...
Reinstalling: bash;5.2.26-3.fc40;x86_64;f41-build

(microdnf:2616): libdnf-WARNING **: 14:37:10.710: cannot find bash in uninst-start

(microdnf:2616): libdnf-WARNING **: 14:37:10.710: cannot find bash in uninst-progress

(microdnf:2616): libdnf-WARNING **: 14:37:10.710: cannot find bash in uninst-progress
Complete.

This is a regression triggered by 85432df commit.
@ppisar ppisar changed the title Reinstalling a packge warns "cannot find bash in uninst-start" Reinstalling a packge warns "cannot find THE_PACKAGE in uninst-start" Apr 17, 2024
@ppisar
Copy link
Contributor Author

ppisar commented Apr 18, 2024

@kontura, could you look at it?

@kontura kontura self-assigned this Apr 18, 2024
kontura added a commit to kontura/libdnf that referenced this issue May 3, 2024
@kontura
Since we use rpmtsAddReinstallElement rpm also uninstalls the package
19f358f 
It calls callbacks for `RPMCALLBACK_INST_START` and
`RPMCALLBACK_INST_PROGRESS` just like before when the reinstall was done
through regural install (rpmtsAddInstallElement) but in addition it also
calls `RPMCALLBACK_UNINST_START` and `RPMCALLBACK_UNINST_PROGRESS`. To
ensure they find the `DnfPackage` add it to `remove_helper` array.

Unfortunaly this means that the reinstall action is reported twice to
the clients (one install and one uninstall). We could try to hide one of
the them but I think a better solution is to report what is actually
happening.

Fixes: rpm-software-management#1653
@kontura kontura mentioned this issue May 3, 2024
Merged
kontura added a commit to kontura/libdnf that referenced this issue May 3, 2024
@kontura
Since we use rpmtsAddReinstallElement rpm also uninstalls the package
60c328f 
It calls callbacks for `RPMCALLBACK_INST_START` and
`RPMCALLBACK_INST_PROGRESS` just like before when the reinstall was done
through regural install (rpmtsAddInstallElement) but in addition it also
calls `RPMCALLBACK_UNINST_START` and `RPMCALLBACK_UNINST_PROGRESS`. To
ensure they find the `DnfPackage` add it to `remove_helper` array.

Unfortunaly this means that the reinstall action is reported twice to
the clients (one install and one uninstall). We could try to hide one of
the them but I think a better solution is to report what is actually
happening and report one install and one uninstall.

This is for the context part of libdnf (microdnf, packagekit, ...)

Fixes: rpm-software-management#1653
jan-kolarik pushed a commit that referenced this issue May 15, 2024
@kontura @jan-kolarik
Since we use rpmtsAddReinstallElement rpm also uninstalls the package
bc37168 
It calls callbacks for `RPMCALLBACK_INST_START` and
`RPMCALLBACK_INST_PROGRESS` just like before when the reinstall was done
through regural install (rpmtsAddInstallElement) but in addition it also
calls `RPMCALLBACK_UNINST_START` and `RPMCALLBACK_UNINST_PROGRESS`. To
ensure they find the `DnfPackage` add it to `remove_helper` array.

Unfortunaly this means that the reinstall action is reported twice to
the clients (one install and one uninstall). We could try to hide one of
the them but I think a better solution is to report what is actually
happening and report one install and one uninstall.

This is for the context part of libdnf (microdnf, packagekit, ...)

Fixes: #1653
ppisar pushed a commit to ppisar/libdnf that referenced this issue May 16, 2024
@kontura @ppisar
Since we use rpmtsAddReinstallElement rpm also uninstalls the package
315d558 
Upstream commit: bc37168

It calls callbacks for `RPMCALLBACK_INST_START` and
`RPMCALLBACK_INST_PROGRESS` just like before when the reinstall was done
through regural install (rpmtsAddInstallElement) but in addition it also
calls `RPMCALLBACK_UNINST_START` and `RPMCALLBACK_UNINST_PROGRESS`. To
ensure they find the `DnfPackage` add it to `remove_helper` array.

Unfortunaly this means that the reinstall action is reported twice to
the clients (one install and one uninstall). We could try to hide one of
the them but I think a better solution is to report what is actually
happening and report one install and one uninstall.

This is for the context part of libdnf (microdnf, packagekit, ...)

Fixes: rpm-software-management#1653
Resolves: https://issues.redhat.com/browse/RHEL-1454
kontura added a commit that referenced this issue May 20, 2024
@kontura
Since we use rpmtsAddReinstallElement rpm also uninstalls the package
7a3d4ed 
Upstream commit: bc37168

It calls callbacks for `RPMCALLBACK_INST_START` and
`RPMCALLBACK_INST_PROGRESS` just like before when the reinstall was done
through regural install (rpmtsAddInstallElement) but in addition it also
calls `RPMCALLBACK_UNINST_START` and `RPMCALLBACK_UNINST_PROGRESS`. To
ensure they find the `DnfPackage` add it to `remove_helper` array.

Unfortunaly this means that the reinstall action is reported twice to
the clients (one install and one uninstall). We could try to hide one of
the them but I think a better solution is to report what is actually
happening and report one install and one uninstall.

This is for the context part of libdnf (microdnf, packagekit, ...)

Fixes: #1653
Resolves: https://issues.redhat.com/browse/RHEL-1454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kontura kontura

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Since we use rpmtsAddReinstallElement rpm also uninstalls the package kontura/libdnf
2 participants
@ppisar @kontura