Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove DNF from list of protected packages" #1619

Closed
wants to merge 1 commit into from
Closed

Revert "Remove DNF from list of protected packages" #1619

wants to merge 1 commit into from

Conversation

inknos
Copy link
Contributor

@inknos inknos commented Aug 28, 2023

This reverts commit a283cc4.

@inknos inknos mentioned this pull request Aug 28, 2023
Merged
@evan-goode evan-goode self-assigned this Aug 28, 2023
evan-goode
evan-goode reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@evan-goode evan-goode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we need both the hardcoded protection here in libdnf AND the file in /etc/dnf/protected.d. How about we just have the file? It's less "magical" and more visible to the user.

@inknos inknos mentioned this pull request Aug 29, 2023
Closed
@inknos
Copy link
Contributor Author

inknos commented Aug 29, 2023

I am ok with discarding this PR and keeping only the protected.d file

@inknos inknos closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-goode evan-goode evan-goode left review comments

@j-mracek j-mracek Awaiting requested review from j-mracek

Assignees

@evan-goode evan-goode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inknos @evan-goode