-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back hardcoded self-protection of dnf
#1621
Add back hardcoded self-protection of dnf
#1621
Conversation
Requires: rpm-software-management/dnf#1991 |
just one small note. could you edit the commit message following the contribution format? |
Now that obsoletion of protected packages is allowed (rpm-software-management#1610), it's best to hardcode the protection of dnf here instead of using the file in /etc/dnf/protected.d. This way, DNF 4 cannot uninstall itself, but DNF 5 can uninstall DNF 4, and likewise (given a similar change in DNF 5), DNF 5 cannot uninstall itself, but DNF 4 can uninstall DNF 5. Related: https://bugzilla.redhat.com/show_bug.cgi?id=2221905 Related: https://bugzilla.redhat.com/show_bug.cgi?id=2221907 = changelog = msg: Allow dnf to be removed by DNF 5 type: enhancement
fb562f7
to
a2804d5
Compare
Sure, I updated the commit message and bumped the version to 0.71.1. Pinging @jan-kolarik since he is currently doing the releases. |
Require new version of libdnf so that dnf remains a protected package, see rpm-software-management/libdnf#1621.
Thanks for the ping, the changes look OK to me, just the thing that in the PR, |
Well, the change in |
Yeah, you're right. When I was looking at this first, I was quite narrow-minded. |
Require new version of libdnf so that dnf remains a protected package, see rpm-software-management/libdnf#1621.
Now that obsoletion of protected packages is allowed (#1610), it's best to hardcode the protection of dnf here instead of using the file in
/etc/dnf/protected.d
. This way, DNF 4 cannot uninstall itself, but DNF 5 can uninstall DNF 4, and likewise (given a similar change in DNF 5), DNF 5 cannot uninstall itself, but DNF 4 can uninstall DNF 5.Related: https://bugzilla.redhat.com/show_bug.cgi?id=2221905
Related: https://bugzilla.redhat.com/show_bug.cgi?id=2221907