Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reinstalling installonly packages marked for ERASE #1625

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Sep 25, 2023

Without this patch reinstalling installonly pkg marked for ERASE might be a valid smallest solution to our job. To make sure it doesn't happen mark the available package also as ERASE.

openSUSE/libsolv#540

https://issues.redhat.com/browse/RHEL-1253
(https://bugzilla.redhat.com/show_bug.cgi?id=2163474)

Tests: rpm-software-management/ci-dnf-stack#1391

Without this patch reinstalling installonly pkg marked for ERASE might
be a valid smallest solution to our job.

For example when user wants to install through a provide we select all
packages that provide it and put them inside a `job install oneof ...`
if one of the providers is also marked for ERASE due to installonly
limit libsolv might decide to reinstall it.

To make sure it doesn't happen mark the available package also as ERASE.

openSUSE/libsolv#540

https://issues.redhat.com/browse/RHEL-1253
(https://bugzilla.redhat.com/show_bug.cgi?id=2163474)
@kontura kontura force-pushed the dnf-4-master-avoid_reinstalling_installonly branch from d381eae to 6f746cb Compare September 26, 2023 08:18
@kontura kontura marked this pull request as ready for review September 26, 2023 08:20
@j-mracek
Copy link
Contributor

Looks perfect

@j-mracek j-mracek self-assigned this Oct 3, 2023
@j-mracek j-mracek merged commit 4b016ce into rpm-software-management:dnf-4-master Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants