dnf-repo: Don't download repository if our local cache is up to date #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleasto
commented
Sep 28, 2023
libdnf/dnf-repo.cpp
Outdated
| @@ -969,6 +969,8 @@ dnf_repo_set_keyfile_data(DnfRepo *repo, gboolean reloadFromGKeyFile, GError **e | |||
| dnf_repo_apply_setopts(*conf, repoId); | |||
| } | |||
|
|
|||
| conf->basecachedir().set(libdnf::Option::Priority::REPOCONFIG, dnf_context_get_cache_dir(priv->context)); | |||
There was a problem hiding this comment.
Not sure if this is the right place to do so, but we need to set basecachedir at some point.
aleasto
force-pushed
the
refresh
branch
5 times, most recently
from
6c5eca2
to
730dd1a
Compare
|
I put the check in the But the integration test is still failing. Where should this be put so that frontends are aware we're downloading new metadata? After |
Verified by comparing the hash of repomd.xml
|
Done |
|
This considerably speeds up the time to refresh in microdnf but most importantly in PackageKit. It improves the experience of using Gnome Software or Plasma Discover |
Conan-Kudo
approved these changes
Sep 29, 2023
Conan-Kudo
merged commit e7cf3d1
into
rpm-software-management:dnf-4-master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified by comparing the hash of repomd.xml