Split $releasever to $releasever_major and $releasever_minor #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase this PR? |
evan-goode
force-pushed
the
evan-goode/releasever-major-minor
branch
from
a121ef7
to
2fd7ab2
Compare
|
Rebased |
Conan-Kudo
requested changes
Oct 11, 2023
This functionality is also implemented in DNF 4, but direct consumers of libdnf (PackageKit, microdnf) also need it. DNF 4 PR: rpm-software-management/dnf#1989 For https://bugzilla.redhat.com/show_bug.cgi?id=1789346
evan-goode
force-pushed
the
evan-goode/releasever-major-minor
branch
from
2fd7ab2
to
a891c02
Compare
Conan-Kudo
approved these changes
Oct 11, 2023
Conan-Kudo
merged commit 1f0964f
into
rpm-software-management:dnf-4-master
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is also implemented in DNF 4, but direct consumers of libdnf (PackageKit, microdnf) also need it, so I've implemented it here in libdnf's ConfigParser. The logic to actually split the releasever is simple enough that I think it's alright to duplicate it.
Blocked by #1622.
DNF 4 PR: rpm-software-management/dnf#1989
For https://bugzilla.redhat.com/show_bug.cgi?id=1789346