context: use rpmtsAddReinstallElement() when doing a reinstall
#1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rpmtsAddInstallElement()` doesn't work for all reinstall cases, such as when a package `Provides` and `Conflicts` with the same capability. Fixes: rpm-software-management/microdnf#137
|
LGTM, but lot of tests are failing on F40+ (but possibly unrelated) ... |
I have check it and the fails are indeed not related. Most of them are caused by a change in |
jan-kolarik
approved these changes
Apr 12, 2024
jan-kolarik
merged commit 85432df
into
rpm-software-management:dnf-4-master
9 of 11 checks passed
|
I don't see how this can make a difference with non-ancient rpm versions. |
|
(OTOH maybe libdnf does a install instead of an update?) |
For updates it is using rpmtsAddInstallElement(...) with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpmtsAddInstallElement()doesn't work for all reinstall cases, such as when a packageProvidesandConflictswith the same capability.Fixes: rpm-software-management/microdnf#137