repo: Don't try to perform labeling if SELinux is disabled #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default for container execution is that `/sys/fs/selinux` is not mounted, and the libselinux library function `is_selinux_enabled` should be used to dynamically check if the system should attempt to perform SELinux labeling. This is how it's done by rpm, ostree, and systemd for example. But this code unconditionally tries to label if it finds a policy, which breaks in an obscure corner case when executed inside a container that includes policy files (e.g. fedora/rhel-bootc) but when we're not using overlayfs for the backend (with BUILDAH_BACKEND=vfs).
enriquebelarte
added a commit
to enriquebelarte/ai-lab-recipes-upstream
that referenced
this pull request
Jun 13, 2024
Konflux CI fails when building using bootc images as base throwing this error: This temporary workaround is needed for build pipeline to work on Konflux CI until libdnf fix is merged to RHEL. https://issues.redhat.com/browse/RHEL-39796 rpm-software-management/libdnf#1665
enriquebelarte
added a commit
to enriquebelarte/ai-lab-recipes-upstream
that referenced
this pull request
Jun 13, 2024
Konflux CI fails when building using bootc images as base throwing this error: `Error: Cannot create repo temporary directory "/var/cache/dnf/baseos-044cae74d71fe9ea/libdnf.1jsyRp": Permission denied` This temporary workaround is needed for build pipeline to work on Konflux CI until libdnf fix is merged to RHEL. References: https://issues.redhat.com/browse/RHEL-39796 rpm-software-management/libdnf#1665 This should be removed once the permanent fix is merged. Signed-off-by: Enrique Belarte Luque <ebelarte@redhat.com>
jan-kolarik
approved these changes
Jun 19, 2024
jan-kolarik
merged commit d264065
into
rpm-software-management:rhel-9.5
2 of 3 checks passed
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for container execution is that
/sys/fs/selinuxis not mounted, and the libselinux library functionis_selinux_enabledshould be used to dynamically check if the system should attempt to perform SELinux labeling.This is how it's done by rpm, ostree, and systemd for example.
But this code unconditionally tries to label if it finds a policy, which breaks in an obscure corner case
when executed inside a container that includes policy files (e.g. fedora/rhel-bootc) but when we're not using overlayfs for the backend (with BUILDAH_BACKEND=vfs).