Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #326 #327

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Issue #326 #327

merged 1 commit into from
Oct 9, 2024

Conversation

crazymind1337
Copy link
Contributor

Convert all xattr strings to lower case to be compatible to Amazon S3 buckets.

@crazymind1337
Issue rpm-software-management#326
2843fe6 
Convert all xattr strings to lower case to be compatible to Amazon S3 buckets.
@m-blaha
Copy link
Member

m-blaha commented Oct 8, 2024

Resolves: #326

@m-blaha m-blaha linked an issue Oct 8, 2024 that may be closed by this pull request
Upper case xattr incompatible to Amazon S3 #326
Closed
@m-blaha m-blaha self-assigned this Oct 8, 2024
m-blaha added a commit to rpm-software-management/ci-dnf-stack that referenced this pull request Oct 9, 2024
@m-blaha
Adjust reposync-xattrs test to renamed attributes
e28d71f 
The xattrs used by librepo to store checksums has been changed to lower
case (see rpm-software-management/librepo#327).

This adjusts tests depending on xattrs to pass with both variants.
@m-blaha m-blaha mentioned this pull request Oct 9, 2024
Merged
@m-blaha
Copy link
Member

m-blaha commented Oct 9, 2024

This change requires adjustment in our integration tests suite. Here is the PR: rpm-software-management/ci-dnf-stack#1561

@m-blaha
Copy link
Member

m-blaha commented Oct 9, 2024

What's bothering me is why the DNF CI / DNF4 Integration Tests check has passed.

It looks like the distribution version of librepo was used, not the one from this PR. Here the xattrs are checked and apparently they were stored with upper case Librepo:

2024-10-08T09:48:32.9146024Z     When I execute "getfattr --dump /synced/x86_64/labirinto-1.0-1.fc29.x86_64.rpm"                          # common/cmd.py:30
2024-10-08T09:48:32.9146992Z     Then stdout matches line by line                                                                         # common/output.py:119
2024-10-08T09:48:32.9147637Z       """
2024-10-08T09:48:32.9148402Z       # file: synced/x86_64/labirinto-1\.0-1\.fc29\.x86_64\.rpm
2024-10-08T09:48:32.9149336Z       user\.Librepo\.checksum\.mtime="[0-9]+"
2024-10-08T09:48:32.9150078Z       user\.Librepo\.checksum\.sha256="[0-9a-f]{64}"
2024-10-08T09:48:32.9150828Z       user\.Librepo\.checksum\.sha512="[0-9a-f]{128}"
2024-10-08T09:48:32.9151424Z       """

@m-blaha
Copy link
Member

m-blaha commented Oct 9, 2024

Oh, there is already an issue for it: #303

@m-blaha m-blaha merged commit f8b0b59 into rpm-software-management:master Oct 9, 2024
6 checks passed
kontura pushed a commit to rpm-software-management/ci-dnf-stack that referenced this pull request Oct 9, 2024
@m-blaha @kontura
Adjust reposync-xattrs test to renamed attributes
6e13360 
The xattrs used by librepo to store checksums has been changed to lower
case (see rpm-software-management/librepo#327).

This adjusts tests depending on xattrs to pass with both variants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-blaha m-blaha m-blaha approved these changes

Assignees

@m-blaha m-blaha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upper case xattr incompatible to Amazon S3
2 participants
@crazymind1337 @m-blaha