Remove cycles from CMake dependency graph #2820
Conversation
Attempts to generate a Ninja build from the existing CMake structure failed complaining about phony cycles related to the use of `add_custom_target` and placing the primary output file in the `DEPENDS` option.
| @@ -434,17 +434,17 @@ function(add_tarball targetname namever treeish) | |||
| set(distname ${tarname}.bz2) | |||
| set(docname ${namever}-doc.${distfmt}) | |||
|
|
|||
| add_custom_target(${docname} | |||
| DEPENDS man apidoc | |||
| file(GLOB man_pages docs/man/*.[1-8]) | |||
There was a problem hiding this comment.
What's the reason for this? AFAICS the tarball gets updated on man page changes as it is, through the "man" target.
|
Right, I remember encountering this pattern somewhere. Always looked like one of those cmake WTFs for me, which is probably why I tried to find some other way to do it. And as such, it was probably always for the worse. I'll accept changing this for correctness, but note that we officially only support "make" based builds as per INSTALL. |
|
Just FWIW, https://gitlab.kitware.com/cmake/cmake/-/issues/22852 describes this very case. |
Okay, I get that. |
|
Solved a bit differently by just dropping the bogus BYPRODUCTS directives: #2900 Thanks for reporting, and the patch even if it didn't get used as-is! |
Attempts to generate a Ninja build from the existing CMake structure failed complaining about phony cycles related to the use of
add_custom_targetand placing the primary output file in theDEPENDSoption.