add support for refactor log script files #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove unneeded whitespace changes |
ErikEJ
reviewed
Sep 2, 2020
src/DacpacTool/Program.cs
Outdated
| @@ -94,7 +96,7 @@ private static int BuildDacpac(BuildOptions options) | |||
| } | |||
|
|
|||
| // Save the package to disk | |||
| packageBuilder.SaveToDisk(options.Output); | |||
| packageBuilder.SaveToDisk(options.Output, new PackageOptions() { RefactorLogPath = options.RefactorLog.FullName }); | |||
There was a problem hiding this comment.
Add null check before getting .FullName
jmezach
reviewed
Sep 2, 2020
test/TestProjectWithPrePost/RefactorLog/TestProjectWithPrePost.refactorlog
Show resolved
Hide resolved
ErikEJ
reviewed
Sep 2, 2020
src/DacpacTool/PackageBuilder.cs
Outdated
| { | ||
| // Ensure that the model has been created and metadata has been set | ||
| EnsureModelCreated(); | ||
| EnsureModelValidated(); | ||
| EnsureMetadataCreated(); | ||
|
|
ErikEJ
reviewed
Sep 2, 2020
src/DacpacTool/Program.cs
Outdated
| @@ -129,7 +131,8 @@ private static int DeployDacpac(DeployOptions options) | |||
| } | |||
|
|
|||
| deployer.UseTargetServer(options.TargetServerName); | |||
|
|
|||
|
|
|||
ErikEJ
reviewed
Sep 2, 2020
| @@ -8,7 +8,6 @@ | |||
| <!-- | |||
| Set LanguageTargets to Microsoft.Common.targets for any project that the SDK won't (.proj, .noproj, etc) | |||
| https://github.com/dotnet/sdk/blob/50ddfbb91be94d068514e8f4b0ce1052156364a0/src/Tasks/Microsoft.NET.Build.Tasks/sdk/Sdk.targets#L28 | |||
|
|
|||
There was a problem hiding this comment.
Revert removed line breaks (?)
There was a problem hiding this comment.
Sorry, could not see it was whitespace removals...
|
Sorry for the unnecessary code changes with whitespace. |
|
Perhaps we should add an |
|
LGTM! @ErikEJ Are you okay with this as well? |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for .refactorlog files handled by the original
.sqlproj#45