This repository has been archived by the owner on Dec 3, 2018. It is now read-only.
Minors on error #12
Merged
Minors on error #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrdelaney
reviewed
Jun 13, 2017
| @@ -35,7 +35,7 @@ const runBsbSync = () => { | |||
| const getBsbErrorMessages = err => err.match(/File [\s\S]*?:\nError: [\s\S]*?\n/g) | |||
|
|
|||
| const getCompiledFile = (moduleDir, path, callback) => { | |||
| runBsb((err, res) => { | |||
| runBsb((err, _, res) => { | |||
There was a problem hiding this comment.
As the doc https://nodejs.org/api/child_process.html#child_process_child_process_execfile_file_args_options_callback shows, callback's parameters are (error, stdout, stderr), we only care the stderr for emitting error.
There was a problem hiding this comment.
As screenshot shows, the BSB check build spec : OK is not error.
|
Published as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.