This repository has been archived by the owner on Dec 3, 2018. It is now read-only.
Fix for bs platform 4.0.5 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it on local, bsb-js version in bs-loader/package.json should be update to new one without -color option for make it work, for my test I use reference to local directory (../bsb-js) P.S. I'm not sure if make PR without make issue is correct way to contribute, if is not I'm sorry |
|
@lorenzo-pomili thanks! released as bs-loader 2.0.6 |
|
oh this was in bsb-js 🤦♂️ |
|
Released as bsb-js 1.1.7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed parameter "-color" passed to bsbCommand because it seemed have no effect and give error when you try to use loader with bs-platform version 4.0.5, all test is green but I have problem to make test in real project from local version of bs-loader and make test on MacOS, so this 2 tests should be done before merge