Skip to content
This repository has been archived by the owner on Dec 3, 2018. It is now read-only.

Colorful error messages #16

Closed
baransu opened this issue Sep 16, 2017 · 2 comments · Fixed by rrdelaney/bs-loader#29
Closed

Colorful error messages #16

baransu opened this issue Sep 16, 2017 · 2 comments · Fixed by rrdelaney/bs-loader#29

Comments

@baransu
Copy link

baransu commented Sep 16, 2017

Currently while stumbling upon error, messages are single color.

screen shot 2017-09-16 at 23 42 10

While building using bs-platform from CLI error messages are nicely colored.

screen shot 2017-09-16 at 23 42 20

I was trying to find where the problem is but I don't know which part of the stack is causing it (reason-scripts, bs-loader, react-dev-utils/WebpackDevServerUtils or maybe webpack).
I would really like to work on PR bringing colors to error messages 🙂

@rrdelaney
Copy link
Owner

Hey @baransu! Thanks for opening this issue 😄

This would need to be done in the bs-loader repo. Right now bs-loader pretty much does "exec('bsb -make-world')". We would need the NodeJS "exec" call to capture the colored output from bsb and then return it to Webpack.

It's awesome that you'd like to make a PR to fix this! I recommend checking out the bs-loader source code, and the documentation for NodeJS's child_process library

cc @chenglou

@rrdelaney
Copy link
Owner

This should be released now 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants