Skip to content
This repository has been archived by the owner on Dec 3, 2018. It is now read-only.

Preserve output color #29

Merged
merged 4 commits into from
Sep 19, 2017
Merged

Conversation

baransu
Copy link
Contributor

@baransu baransu commented Sep 17, 2017

Attempt to fix: rrdelaney/reason-scripts#16

Because linux and macOS have different behaviours we have to distinguish those two. That's why I've updated .travis.yml to run tests both on linux and osx

Previously:

screen shot 2017-09-16 at 23 42 10

Now:

screen shot 2017-09-17 at 17 48 07

Which is matching bs-platform CLI command:

screen shot 2017-09-16 at 23 42 20

Huge thanks to @wende for helping with the correct command.

@rrdelaney
Copy link
Owner

Thanks so much! This is awesome 😎

Did you get the chance to test this on Windows? I don't have access to a Windows machine right now 😕

If not, when this is merged we can set up a beta release and ask for people to test on Windows though

@baransu
Copy link
Contributor Author

baransu commented Sep 18, 2017

Unfortunately I've only tested it on macOS and in case of linux I'm relying on Travis.

@rrdelaney rrdelaney merged commit 038721c into rrdelaney:master Sep 19, 2017
@baransu baransu deleted the fix/bsb-output-color branch March 16, 2018 00:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colorful error messages
2 participants