use reflect.Value directly

rrgmc · Jul 8, 2023 · a1ca14f · a1ca14f
1 parent f485302
commit a1ca14f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/decode_input.go b/decode_input.go
@@ -40,7 +40,7 @@ func (d *Decoder[IT, DC]) decodeInputFromStructInfo(input IT, si *structInfo, da
 		}
 	}
 
-	err := d.decodeStruct(si, input, data, decodeOptions)
+	err := d.decodeStruct(si, input, reflect.ValueOf(data), decodeOptions)
 	if err != nil {
 		return err
 	}

diff --git a/decode_struct.go b/decode_struct.go
@@ -8,8 +8,8 @@ import (
 )
 
 // decodeStruct uses the structInfo to decode the input to the struct.
-func (d *Decoder[IT, DC]) decodeStruct(si *structInfo, input IT, data interface{}, decodeOptions DecodeOptions[IT, DC]) error {
-	dataValue := reflectValueElem(reflect.ValueOf(data))
+func (d *Decoder[IT, DC]) decodeStruct(si *structInfo, input IT, dataValue reflect.Value, decodeOptions DecodeOptions[IT, DC]) error {
+	dataValue = reflectValueElem(dataValue)
 	if err := si.checkSameType(dataValue.Type()); err != nil {
 		return err
 	}
@@ -32,7 +32,7 @@ func (d *Decoder[IT, DC]) decodeStruct(si *structInfo, input IT, data interface{
 		case OperationRecurse:
 			// recurse into inner struct
 			reflectEnsurePointerValue(&fieldValue)
-			if err := d.decodeStruct(sifield, input, fieldValue.Addr().Interface(), decodeOptions); err != nil {
+			if err := d.decodeStruct(sifield, input, fieldValue, decodeOptions); err != nil {
 				return err
 			}
 			dataWasSet = true