Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #10 - Component trigger many internet calls #11

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

elad-bar
Copy link
Contributor

  • Moved logic (__init__.py) of whether to trigger firmware update before checking state, so state will be able to use the latest update
  • Wrap the check whether it's time to check firmware update as variable and pass it to the async_get_state of both client.py and client_wax.py
  • Moved the state request data to consts.py and removed sections FwUpdate and monitor parameter of internetConnectivityStatus
  • Add IF statement to check if the internet connectivity was not checked since it was loaded or over the last hour, in case it is time to check, add internetConnectivityStatus to monitors
  • Add IF statement to check if the firmware update function ran, in case it did, will add the FwUpdate section

Tested in local environment, working great.

@rroller
Copy link
Owner

rroller commented Mar 17, 2022

Amazing! Thank you!

@rroller rroller self-requested a review March 17, 2022 18:36
@rroller rroller merged commit 554dc1a into rroller:main Mar 17, 2022
@rroller
Copy link
Owner

rroller commented Mar 17, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants