(riverpod_lint) Add new lint avoid_passing_build_context_to_providers #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2928 +/- ##
=======================================
Coverage 95.24% 95.24%
=======================================
Files 53 53
Lines 2252 2252
=======================================
Hits 2145 2145
Misses 107 107 |
rrousselGit
reviewed
Sep 27, 2023
.../riverpod_lint_flutter_test/test/goldens/lints/avoid_passing_build_context_to_providers.dart
Outdated
Show resolved
Hide resolved
rrousselGit
reviewed
Sep 28, 2023
Comment on lines
8
to
9
| TypeChecker buildContextType = | ||
| const TypeChecker.fromName('BuildContext', packageName: 'flutter'); |
There was a problem hiding this comment.
Suggested change
| TypeChecker buildContextType = | |
| const TypeChecker.fromName('BuildContext', packageName: 'flutter'); | |
| const buildContextType = TypeChecker.fromName( | |
| 'BuildContext', | |
| packageName: 'flutter', | |
| ); |
rrousselGit
reviewed
Sep 28, 2023
Comment on lines
47
to
55
| final buildContextParameters = parameters.parameters.where( | ||
| (e) => | ||
| e.declaredElement?.type != null && | ||
| buildContextType.isExactlyType(e.declaredElement!.type), | ||
| ); | ||
|
|
||
| for (final contextParameter in buildContextParameters) { | ||
| reporter.reportErrorForNode(_code, contextParameter); | ||
| } |
There was a problem hiding this comment.
Could this be refactored with the functional-based bit to avoid the duplicate?
A function which takes the list of parameter and emit warnings should be fine.
|
Outside of a small DRY thingy, LGTM! Ah yes, one more thing: I'm not sure about the name picked. It's a bit lengthy. |
|
Definitely. I am not good at naming. |
|
Perfect. I'll sync with master, check the CI and merge/deploy this |
… pr/charlescyt/2928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a lint for #2187