Merge pull request #1090 from antedeguemon/vm-fixes-unused-function-f…

…rom-mix-env-check

Fixes unused function warning in MixEnv check

lib/credo/check/warning/mix_env.ex

@@ -53,7 +53,7 @@ defmodule Credo.Check.Warning.MixEnv do
 
   for op <- @def_ops do
     # catch variables named e.g. `defp`
-    defp traverse({unquote(op), _, nil} = ast, issues, _issue_meta, _parens?) do
+    defp traverse({unquote(op), _, nil} = ast, issues, _issue_meta) do
       {ast, issues}
     end
 

test/credo/check/warning/mix_env_test.exs

@@ -124,4 +124,18 @@ defmodule Credo.Check.Warning.MixEnvTest do
     |> run_check(@described_check)
     |> assert_issue()
   end
+
+  test "it should report violations from variables named like def operations" do
+    """
+    defmodule CredoSampleModule do
+      def some_function do
+        def = Mix.env()
+        defp = &Mix.env/0
+      end
+    end
+    """
+    |> to_source_file
+    |> run_check(@described_check)
+    |> assert_issues()
+  end
 end