Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI (Test against OTP 26, 24.3 instead of 24, 1.16 rc) #1092

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

PragTob
Copy link
Contributor

@PragTob PragTob commented Nov 17, 2023

Commits mostly stand by themselves and should include rational, I can spin off more PRs if wanted but they were somehow related

I think the previous PR rrrene#1089 accidentally added it to exclude
instead of include as 26.1 was nowhere to be seen.
* Bring the erlang version inline with 26.1 on CI
* be explicit about the erlang compiled version to avoid surprises
Since it's already in .tool-versions, may as well 👀
@PragTob
Copy link
Contributor Author

PragTob commented Nov 17, 2023

The one failing 1.16.0-rc.0 is due to #1091 (which is partially why added this, as I wanted to see it fail in CI), so this is working as intended 😁

Thanks for all your work! 💚

@rrrene rrrene merged commit a3c0608 into rrrene:master Nov 17, 2023
11 of 12 checks passed
@PragTob PragTob deleted the upgrade-ci branch November 17, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants