Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata in logger for 1.15 Elixir #1097

Closed
wants to merge 2 commits into from
Closed

Conversation

hissssst
Copy link

@hissssst hissssst commented Dec 1, 2023

Fixes #1070

@rrrene
Copy link
Owner

rrrene commented Dec 13, 2023

@hissssst Thank you for putting this together. As you can see in the checks, it unfortunately doesn't work in the greater scheme of things for Credo.

That being said, your PR inspired the commit referenced above, which should fix this for all supported versions of Elixir 👍

You can try this by setting the Credo dep to

{:credo, github: "rrrene/credo"}

Please report back if this works for your use-case 👍

@hissssst hissssst closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MissedMetadataKeyInLoggerConfig is incorrect
2 participants