Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nested starting style #4

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

jantimon
Copy link

my last pr missed the case for nested @starting-style rules

for example:

@starting-style { @media (max-width:991px) { .demo { background-color: #f00; } } }

and

@media (max-width:991px) { @starting-style { .demo { background-color: #f00; } } }

Copy link

changeset-bot bot commented May 31, 2024

🦋 Changeset detected

Latest commit: 29c6aec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
rrweb-cssom Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jantimon
Copy link
Author

jantimon commented Jun 11, 2024

@YunFeng0817 could you please take a look?

Could you maybe also allow to create issues for this repository?

@YunFeng0817
Copy link
Member

@YunFeng0817 could you please take a look?

Could you maybe also allow to create issues for this repository?

Sounds good

@YunFeng0817 YunFeng0817 merged commit 6e61048 into rrweb-io:master Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants