feat: Ensure password inputs are masked when switching type #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2869161 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
YunFeng0817
reviewed
Mar 18, 2023
Apply formatting changes use data- attribute ref: Ensure type is always lowercased add changeset
mydea
force-pushed
the
fn/handle-password-type-change
branch
from
22757c8
to
40be43a
Compare
This was referenced Mar 23, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves masking of
<input type="password">elements in the case that theirtypeis switched totext. This is quite common in modern UI, where often you have a button to "show password" while typing it. We should still mask this content in that case as if it was a password, in order to prevent accidentally capturing this unmasked.This is done by adding an
data-rr-is-passwordattribute to the input in the case where the type is changed frompasswordto something else.Note: While at it, I also changed the code to actually accommodate uppercase type, as e.g.
<input type="PASSWORD">is valid but would not have been masked previously, as we never converted the type to lowercase.