Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact style mutation fixes and improvements #1268

Merged
merged 12 commits into from
Aug 3, 2023

Commits on Jul 27, 2023

  1. Configuration menu
    Copy the full SHA
    b25d447 View commit details
    Browse the repository at this point in the history
  2. As the CSS Object Model expands out shorthand properties, do a check …

    …on the string length before choosing which format to go for
    
     - this approach allows 'var()' in a styleOMValue as it's only a problem when combined with a shorthand property
     - before this change background:black; was getting expaned to 10 OM properties as follows:
    
    'style': {
        'background-color': 'black',
        'background-image': false,
        'background-position-x': false,
        'background-position-y': false,
        'background-size': false,
        'background-repeat-x': false,
        'background-repeat-y': false,
        'background-attachment': false,
        'background-origin': false,
        'background-clip': false
    }
    eoghanmurray committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    17ba96c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1d0bb07 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    51a2955 View commit details
    Browse the repository at this point in the history
  5. Apply formatting changes

    eoghanmurray authored and github-actions[bot] committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ecc806f View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Update packages/rrweb/src/record/mutation.ts

    Use neater object destructuring
    
    Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
    eoghanmurray and Juice10 authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e1eda15 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    prefer waitForRAF
    
    Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
    eoghanmurray and Juice10 authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    9af639e View commit details
    Browse the repository at this point in the history
  3. Update packages/rrweb/src/record/mutation.ts

    frontload comment explaining what's going on here in terms of the 'var(' string check
    
    Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
    eoghanmurray and Juice10 authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    6c1ca1a View commit details
    Browse the repository at this point in the history
  4. Update packages/rrweb/test/integration.test.ts

    Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
    eoghanmurray and Juice10 authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    f2f1627 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7fb0a5f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    52a31ee View commit details
    Browse the repository at this point in the history
  7. Trigger CI

    Juice10 authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    671b321 View commit details
    Browse the repository at this point in the history