-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to block animation on <title> tag #760
Conversation
I am making use of the Use case - when recording SPAs I would like the |
good point @jlalmes |
Great spot, thanks @jlalmes ... in light of that, maybe it should be a throttling thing? |
Actually @jlalmes, the intention of the This also reminds me that I've got some code external to rrweb which detects Single Page App url changes, but only if they happen in tandem with a <title> tag change. If I were to integrate that in rrweb it would introduce a new event, analogous to the |
Good idea! I will look into that.
Yes, a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, it's missing a type, and would also be great to have a test.
Is also missing a changeset, but this is a pretty old PR so that's totally understandable. Apart from that this looks good!
ff98727
to
7eb049c
Compare
🦋 Changeset detectedLatest commit: 2887191 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I satisfied all the requested changes, not sure how to indicate that!
OK I guess my force push messed things up, as it can't find the commits the requested changes were attached to! |
03c41a8
to
ae11ded
Compare
This will fix the issues with CI not passing on this PR: #1500 |
…ve recordings on some websites (think scrolling title tag)
0be8e98
to
2887191
Compare
* Add option to block animation on <title> tag which can generate massive recordings on some websites (think scrolling title tag) * Add new option to slimDOMOptions type with tsdoc as suggested by Justin
* Add option to block animation on <title> tag which can generate massive recordings on some websites (think scrolling title tag) * Add new option to slimDOMOptions type with tsdoc as suggested by Justin
* Add option to block animation on <title> tag which can generate massive recordings on some websites (think scrolling title tag) * Add new option to slimDOMOptions type with tsdoc as suggested by Justin
These can generate massive recordings on some websites (think scrolling title tag)