chore: upgrade dockerfile #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanhey
reviewed
Oct 6, 2022
| COPY third_party /build/third_party | ||
|
|
||
| # Nginx Docker Playground (https://github.com/nginx-with-docker/nginx-docker-playground) | ||
| FROM soulteary/prebuilt-nginx-modules:base-1.23.1-alpine AS Builder |
There was a problem hiding this comment.
Please, try to use official docker images.
There was a problem hiding this comment.
@soulteary I think joanhey is right. haha
There was a problem hiding this comment.
I agree with this change, and will update this PR once I've finished a piece of content with a better scene, hopefully within the last two months of this year.
eg: https://www.zhihu.com/question/21483073/answer/2647942304
joanhey
suggested changes
Oct 6, 2022
|
|
||
| # Nginx Docker Playground (https://github.com/nginx-with-docker/nginx-docker-playground) | ||
| FROM soulteary/prebuilt-nginx-modules:base-1.23.1-alpine AS Builder | ||
| RUN apk update && apk --no-cache add curl gcc g++ make musl-dev linux-headers gd-dev geoip-dev libxml2-dev libxslt-dev openssl-dev pcre-dev perl-dev pkgconf zlib-dev libedit-dev ncurses-dev php8-dev php8-embed git unzip argon2-dev |
|
@soulteary Maybe github-actions-build was wrong, wait for repair. |
|
Best @soulteary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #143
hope it helps @rryqszq4