Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php 8 major version #186

Merged
merged 5 commits into from
Feb 18, 2024
Merged

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Feb 17, 2024

image

Also fix dynamic modules test.
This PR is for the master branch.

@joanhey
Copy link
Contributor Author

joanhey commented Feb 17, 2024

This need another ngx-php version !!

@rryqszq4 rryqszq4 merged commit 2eb6241 into rryqszq4:master Feb 18, 2024
56 checks passed
@rryqszq4
Copy link
Owner

This need another ngx-php version !!

A new version https://github.com/rryqszq4/ngx-php/releases/tag/v0.0.29

@joanhey joanhey deleted the fix-major-version branch February 18, 2024 16:11
@joanhey
Copy link
Contributor Author

joanhey commented Feb 18, 2024

Change the version

#define NGX_HTTP_PHP_MODULE_VERSION "0.0.28"

@rryqszq4
Copy link
Owner

Change the version

#define NGX_HTTP_PHP_MODULE_VERSION "0.0.28"

Has been changed and re-tag https://github.com/rryqszq4/ngx-php/releases/tag/v0.0.29

@joanhey
Copy link
Contributor Author

joanhey commented Feb 19, 2024

image

https://github.com/TechEmpower/FrameworkBenchmarks/actions/runs/7958592193/job/21723784900?pr=8739#step:9:803

Working OK.
Thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants