This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
Add pubsub http #120
Merged
Add pubsub http #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore the 0072c4d, just a sec... |
koivunej
force-pushed
the
add_pubsub_http
branch
from
0072c4d
to
90a19db
Compare
added 14 commits
March 25, 2020 20:56
currently the missing piece is seeing locally sent messages in the subscribed streams, then maybe creating a more complicated API for subscribing which will require a single task for shoveling into the responses.
Should probably have another drop sender here.
tokio::sync::broadcast will continue after telling how many items were lost, which seems likely with the small buffer and quickly firing more than the buffer elements.
the v0.16.2-with-floodsub-opts includes "subscribers see locally published messages" which is needed for the conformance tests to pass. this has been PR'd as libp2p/rust-libp2p#1520.
koivunej
force-pushed
the
add_pubsub_http
branch
from
e39cf66
to
898d366
Compare
dvc94ch
approved these changes
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
/api/v0/pubsubendpoints. Passing the conformance tests requires a modified libp2p-floodsub which I haven't yet pushed. The required functionality is getting the locally sent messages as if they were received over the swarm published over to subscriber(s).This depends on #118 so creating this as a draft.
Things still to do:
tokio::sync::watchfor the pubsub responses instead of timeout?The latter has not been done. I am currently more interested in lowering the broadcast channel size to less than what the conformance tests use by getting some backpressure in, but that'll have to be later.