Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

feat: http pin/add #342

Merged
merged 13 commits into from
Aug 27, 2020
Merged

feat: http pin/add #342

merged 13 commits into from
Aug 27, 2020

Conversation

koivunej
Copy link
Collaborator

Continued from #152 by @saresend cc #11 .

Closes #152.

This only adds the pin/add per current impl which passes the tests which don't verify anything. I am inclined to merge this in as is since the next PR is likely going to be a larger one.

Checklist (can be deleted from PR description once items are checked)

  • New code is “linted” i.e. code formatting via rustfmt and language idioms via clippy
  • There are no extraneous changes like formatting, line reordering, etc. Keep the patch sizes small!
  • There are functional and/or unit tests written, and they are passing
  • There is suitable documentation. In our case, this means:
    • Each command has a usage example and API specification
    • Rustdoc tests are passing on all code-level comments
    • Differences between Rust’s IPFS implementation and the Go or JS implementations are explained

@koivunej koivunej requested a review from ljedrz August 27, 2020 07:16
Copy link
Member

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
bors r+

@bors
Copy link
Contributor

bors bot commented Aug 27, 2020

Build succeeded:

@bors bors bot merged commit d3c51df into rs-ipfs:master Aug 27, 2020
@aphelionz aphelionz mentioned this pull request Sep 1, 2020
@koivunej koivunej deleted the http_pinning_api branch September 24, 2020 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants