Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding go.mod support. Closes #193 #209

Closed
wants to merge 1 commit into from

Conversation

Dragomir-Ivanov
Copy link
Contributor

No description provided.

Copy link
Owner

@rs rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not include test deps here.

@Dragomir-Ivanov
Copy link
Contributor Author

Dragomir-Ivanov commented Nov 30, 2018

Hmm, I have never worked with mod before, so I read some for this patch.
I find this explanation:

The module download is split into two parts: downloading the go.mod and downloading the actual code. If you have dependencies only needed for tests, then they will show up in your go.mod, and go get will download their go.mods, but it will not download their code. The test-only dependencies get downloaded only when you need it, such as the first time you run go test.

source: golang/go#26913 (comment)

Also, predictability of the testing is as important as the main project.

@smyrman
Copy link
Collaborator

smyrman commented Nov 30, 2018

We could potentially exclude example dependencies by adding a go.mod file to the examples directory and running go build and/or go mod tidy on the relevant packages.

@smyrman
Copy link
Collaborator

smyrman commented Nov 30, 2018

Maybe I can just do it :-)

@smyrman
Copy link
Collaborator

smyrman commented Nov 30, 2018

Moved to #210.

@smyrman smyrman closed this Nov 30, 2018
@Dragomir-Ivanov Dragomir-Ivanov deleted the issue_193 branch November 30, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants