-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for more trace levels? #349
Comments
There is already a logr implementation here: https://github.com/hn8/zerologr |
Oh neat. But it suffers the problem I described here - it doesn't support
V levels higher than 2, which makes it pretty limited.
So back to my original question... :)
…On Thu, Aug 26, 2021, 5:39 PM Olivier Poitrey ***@***.***> wrote:
There is already a logr implementation here:
https://github.com/hn8/zerologr
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#349 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVHOLUN2D5SQJSYZTU3T63NDZANCNFSM5CZN4C5Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
PR welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I'd love to do a logr (https://github.com/go-logr/logr) implementation for zerolog, but they have somewhat different philosophies on levels. logr uses strictly numeric levels. In playing with zerolog, it seems I can set the global level to arbitrary values (e.g. -2 as a "more verbose trace"), but I can't use arbitrary levels in
WithLevel()
.For zap, we made a change that allows semi-arbitrary level numbers, and just bypasses fancy stuff like sampling when those are used.
Before I go and try to make this work in zerolog - is that something you'd be open to? If so, any guidance of preferred impl would be helpful.
The text was updated successfully, but these errors were encountered: