-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to custom order of field in ConsoleWriter #170
Open
TommyCpp
wants to merge
3
commits into
rs:master
Choose a base branch
from
TommyCpp:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r of output. If user didn't specify, then will use dictionary order. In some case, the system have specific requirement for the order of output field. But json is unordered in definition. So we need decode json and reorder. Add test accordingly.
👍 |
@TommyCpp is there any news? |
I don’t think it’s gonna be merged. Haven’t heard from the author. |
a78256a
to
f09463f
Compare
Nice; it would be great if there was a default implementation that ordered by the JSON/Dict keys as that would probably be the most common sort method. |
Any updates on this feature? This would be very helpful. :) |
Just submitted PR #550. Should have checked for previous work first. :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As point out in #155. It would be nice to have some control on the order of the output field.
Add example on how to custom field's order.