Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let user decide what to do if logger is not in context #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Let user decide what to do if logger is not in context #177

wants to merge 1 commit into from

Commits on Aug 13, 2019

  1. Let user decide what to do if logger is not in context 

    As for now disabledLogger is being returned if user tries to get logger from context.Context.
Such a behaviour may be beneficial, but in other cases it will be harmful.
Giving user an option to return nil and fail with nil pointer error may prevent logs loss.
    Tomasz Czermiński committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    6dc7d18 View commit details
    Browse the repository at this point in the history