feat: implement an optional ErrorWriter interface #365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rs no idea if you'll want to merge this - this is something I'll be adopting internally so that errors logged via zerolog at warn level or above can be enriched with request context, then pushed into an external error aggregator; Sentry in my case.
This builds on the idea proposed in #329
A few design notes:
errors need level context, generally. In my use case, I don't want to
send errors below "warn" level to an external error aggregator.
should be injected into the logger on a per-request basis such that
all logged errors are enriched with the same request context.
there to guarantee Discard() behaves correctly, and also that e.g. an
Array that is built up can benefit from the ErrorWriter that may be
embedded within the event it will eventually be attached to.