added support for NO_COLOR #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
rs
requested changes
Sep 4, 2023
console.go
Outdated
| @@ -312,6 +312,11 @@ func needsQuote(s string) bool { | |||
|
|
|||
| // colorize returns the string s wrapped in ANSI code c, unless disabled is true. | |||
| func colorize(s interface{}, c int, disabled bool) string { | |||
| e := os.Getenv("NO_COLOR") | |||
| if e == "true" { | |||
There was a problem hiding this comment.
GNU libtextstyle doc says:
The environment variable NO_COLOR can be used to suppress styling in the textual output. When this environment variable is set (to any value), libtextstyle-enabled programs will not emit colors and other text styling.
There was a problem hiding this comment.
Ahh you are right, fixed the code now.
Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
rs
approved these changes
Sep 4, 2023
madkins23
pushed a commit
to madkins23/zerolog
that referenced
this pull request
Mar 2, 2024
* added support for NO_COLOR Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com> * added unit test for `NO_COLOR` Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com> * NO_COLOR can now be set to anything Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com> --------- Signed-off-by: Lasse Gaardsholt <lasse.gaardsholt@bestseller.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #582