Fix issue where tapping backspace to delete a single letter also selects the previous token #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts the previous token
|
Tested and looks good on iOS 9 |
|
Thank Joel! Almost everything works here. The only issue I'm seeing is that, at least on iOS 8, you can no longer invoke delete on an empty text field to highlight the previous token (like you can in the system picker on iOS). Looking into whether I can tweak your changes to make that work. I understand that iOS 8 is likely in low usage now, but I'd like to keep support for it, if possible. |
|
@rsattar Ok deleting definitely works in iOS 10, pretty sure also in iOS 9. For my company, iOS 8 usage is down to a bit over 1% so I'm realistically not going to fix it - but I suspect conditionally going back to the previous behavior would fix the delete issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for an issue I noticed on iOS 10. I have not tested it for iOS 9 or 8.