Added national holiday for BMF calendar (Black Awareness Day, Nov 20th) #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r 20th) Added new national holiday (Black Awareness Day) on November 20th starting in 2024. The same date was previously a municipal holiday.
Added test for new holiday on Nov 20th starting in 2024
Fix old test that should check November 20th only up to 2023, before new holiday is active.
Fix test conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new national holiday (Black Awareness Day) on November 20th starting in 2024. The same date was a municipal holiday until 2021.
The new holiday is officially added through "Circular Letter 215/2023", published on 2023-12-22 and available here.
Excerpt:
The latest official BMF calendar can be verified here.
I will add new tests next. Because of the old holiday on the same date, the previous test has to be modified with an end date.