Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request addresses Issues #345 and #276.
Issue #345 stemmed from Exchange_Calendar weekmasks not being transferred from the exchange_calendar parent class into the Mirrored TradingCalendar Class. The added function ( linked below ) preserves weekmask's day abbreviation convention even though this isn't strictly necessary.
https://github.com/jack-of-some-trades/pandas_market_calendars/blob/e4afd4fae0efa35c7f3340af2478e3f0a46675ad/pandas_market_calendars/calendars/mirror.py#L103C10-L117C9
Issue #276 stemmed from the "XTAE" exchange_calendar handling the unique sunday close time using the 'special_closes' property. To compensate for this MarketCalendar.special_dates() can now parse a tuple of (time=time, calendar=int) where the calendar can be an int [0,6] which represents the day of the week to repeat. (Changes linked below)
https://github.com/jack-of-some-trades/pandas_market_calendars/blob/e4afd4fae0efa35c7f3340af2478e3f0a46675ad/pandas_market_calendars/market_calendar.py#L641-L652