Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI against JRuby 9.1.9.0 #1342

Merged
merged 1 commit into from
May 18, 2017
Merged

Conversation

koic
Copy link
Collaborator

@koic koic commented May 17, 2017

JRuby 9.1.9.0 has been released.

http://jruby.org/2017/05/16/jruby-9-1-9-0

@yahonda
Copy link
Collaborator

yahonda commented May 17, 2017

(Pointed to the wrong number. 1279 is the correct one)

CI for jruby-9.1.9.0 and ruby-head is failing due to #1279.

There is a similar error generated at simplecov .
https://travis-ci.org/colszowka/simplecov/jobs/232794265

@yahonda
Copy link
Collaborator

yahonda commented May 17, 2017

Opened simplecov-ruby/simplecov#582 to run CI against Ruby 9.1.0.0 to see if it reproduces with simplecov itself.

@koic
Copy link
Collaborator Author

koic commented May 17, 2017

Thanks for your advice.
It seems like a bug in JRuby 9.1.9.0. I will open an issue of JRuby later.

@koic
Copy link
Collaborator Author

koic commented May 17, 2017

I think that this build error will fix with the following PR.

simplecov-ruby/simplecov-html#53

I'd like to see how it goes for a while. How about this?

@yahonda
Copy link
Collaborator

yahonda commented May 17, 2017

Thanks for the investigation.
I'd like to see how jruby/jruby#4610 goes. Since this behavior change looks a regression for me which would affect many other users.

@koic
Copy link
Collaborator Author

koic commented May 17, 2017

Sure. I got it.

@koic koic force-pushed the ci_against_jruby_9_1_9_0 branch from e0f03ad to a9c8b4d Compare May 18, 2017 01:23
@koic
Copy link
Collaborator Author

koic commented May 18, 2017

It was a regression of JRuby 9.1.9.0. This regression issue was included in the milestone of JRuby 9.2.0.0.

https://github.com/jruby/jruby/milestone/53

If they have another regressions it is even better to test with them (That's fail fast) . So I think that it is good to merge this PR. Tell me what you think.

@yahonda yahonda merged commit e93e4dd into rsim:master May 18, 2017
@yahonda
Copy link
Collaborator

yahonda commented May 18, 2017

Really great job. Thank you.

@koic koic deleted the ci_against_jruby_9_1_9_0 branch May 18, 2017 12:50
@koic
Copy link
Collaborator Author

koic commented May 18, 2017

Thanks too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants