Add dbconsole support to adapter #2308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
force-pushed
the
dbconsole_support
branch
2 times, most recently
from
74cfe19
to
bf89b63
Compare
gmcgibbon
commented
Sep 30, 2022
lib/active_record/connection_adapters/oracle_enhanced_adapter.rb
Outdated
Show resolved
Hide resolved
Adds dbconsole method to be used when invoking bin/rails dbconsole. Co-authored-by: Paarth Madan <paarth.madan@shopify.com>
gmcgibbon
force-pushed
the
dbconsole_support
branch
from
bf89b63
to
1276a1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to rails/rails#46093
Adds dbconsole method to be used when invoking bin/rails dbconsole.
Moves dbconsole logic related to Oracle in Rails to the adapter. This connection code and corresponding test was in the dbconsole command in railties.
cc @paarthmadan