This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Rif ui extraction #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
jurajpiar
reviewed
Apr 30, 2020
jurajpiar
approved these changes
Apr 30, 2020
… added relative paths inside the library and removed circular dependencies
itofarina
force-pushed
the
feature/rifUiExtraction
branch
from
cb941ba to
ba1869d
Compare
vojtechsimetka
approved these changes
Apr 30, 2020
julianmrodri
approved these changes
Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on the
rifuifolder and adds the dependency to the library that now lives in RIF-UI repository.It also has the changes that the folder needed in order to be used as a library so we can review those changes here :).
Alert
This PR has a dependency on the new library, pointing to the feature/extraction branch, please make sure it's still alive when reviewing or update the reference to master in the
package.jsonfile, just like this:Known issues
distpath.@rsksmart/rif-ui/theme.