-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new 2wp file starting with one pegin test checking event #87
Merged
marcos-iov
merged 10 commits into
rits-refactors-9-2024-integration
from
create-new-2wp-file
Sep 25, 2024
Merged
Adds new 2wp file starting with one pegin test checking event #87
marcos-iov
merged 10 commits into
rits-refactors-9-2024-integration
from
create-new-2wp-file
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
rename-2wp-file
to
rits-refactors-9-2024-integration
September 17, 2024 15:40
jeremy-then
force-pushed
the
create-new-2wp-file
branch
from
September 24, 2024 00:01
dbea99a
to
13bf6a7
Compare
Quality Gate passedIssues Measures |
marcos-iov
approved these changes
Sep 25, 2024
} | ||
}; | ||
|
||
const PEGIN_EVENTS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for now, but I would consider splitting this file before it grows too much. 2wpConstants, BrideEvents, FedChangeConstants, etc
marcos-iov
merged commit Sep 25, 2024
ecbcc51
into
rits-refactors-9-2024-integration
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr creates a new
lib/tests/2wp.js
file, with one initial pegin test, the most basic pegin.This test checks the initial federation and sender address balances to compare them with the expected final balances.
This test also checks that the
pegin_btc
event is emitted with the expected values.Asserts that the Bridge own balance and the Bridge utxos sum is as expected.