Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing root field from TransactionReceiptDTO #1451

Merged
merged 3 commits into from
Mar 29, 2021

Conversation

ajlopez
Copy link
Contributor

@ajlopez ajlopez commented Feb 17, 2021

Description

Remove the root field from Transaction Receipt DTO (Data Transfer Object) used in JSON RPC serialization

Motivation and Context

It should solve #1328

The root field was never used in current RSK testnet and mainnet, so we don't need to implement it as a hard fork.

How Has This Been Tested?

Some test code was added, testing the result of other field, status.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:
    I recommend intergration tests for this feature

@bguiz
Copy link

bguiz commented Feb 18, 2021

  • Verified that this resolves ethers.js#952
  • Looks like this likely also resolves rskj#1328, further verification may be needed

🙏 @ajlopez !

Copy link

@bguiz bguiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to delete

import co.rsk.crypto.Keccak256;

to address this error

@ajlopez ajlopez force-pushed the remtxrroot branch 3 times, most recently from e675d1b to 88cde74 Compare March 1, 2021 18:25
@ajlopez ajlopez marked this pull request as ready for review March 4, 2021 18:42
@ajlopez ajlopez force-pushed the remtxrroot branch 2 times, most recently from f4b6417 to e60a874 Compare March 19, 2021 11:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ajlopezrsk ajlopezrsk merged commit bf0b7e8 into rsksmart:master Mar 29, 2021
@aeidelman aeidelman added this to the Iris 3.0.0 milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants