Removing root field from TransactionReceiptDTO #1451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
root
field from Transaction Receipt DTO (Data Transfer Object) used in JSON RPC serializationMotivation and Context
It should solve #1328
The
root
field was never used in current RSK testnet and mainnet, so we don't need to implement it as a hard fork.How Has This Been Tested?
Some test code was added, testing the result of other field,
status
.Types of changes
Checklist:
I recommend intergration tests for this feature