Properly handle chunked requests on WebsocketServer

[fernandorubal]

Description

This PR intends to solve a bug when processing incomplete or chunked requests received through the Websocket endpoint.

Motivation and Context

This PR aims to provide a solution to a bug causing chunked requests sent to the Rskj WebSocket Endpoint to be treated as separate requests.

This bug was discovered when using the official Ethereum Go client to send a transaction. The geth client sends data > 1024 bytes in chunks. That caused the Web3WebSocketServer to read every chunk of 1024 bytes as a new request, failing in consequence to process it as a valid json.

Adding the WebsocketFrameAggregator handler to the pipeline provides a way to properly handle those chunked requests.

How Has This Been Tested?

This patch was tested using geth client with successful results

A new test was added in Web3WebSocketServerTest.java called smokeTestWithBigJson that uses the same logic that the original smokeTest, but generates a JSON message that exceeds 2048 bytes (OkHttpClient buffer) so it gets sent chunked to the WebSocket Server.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• Tests for the changes have been added (for bug fixes / features)
• Requires Activation Code (Hard Fork)

• Other information:
  https://netty.io/4.0/api/io/netty/handler/codec/http/websocketx/WebSocketFrameAggregator.html

[fedejinich]

@fernandorubal can you provide some tests for this one?

[Vovchyk]

pipeline: run

[fernandorubal]

@fernandorubal can you provide some tests for this one?

A new test was added in Web3WebSocketServerTest.java called smokeTestWithBigJson that uses the same logic that the original smokeTest, but generates a JSON message that exceeds 2048 bytes (OkHttpClient buffer) so it gets sent chunked to the WebSocket Server.

059ea1c

[horca17]

Hello again, any news? Thanks.

[Vovchyk]

pipeline: run

[jjtechuy]

pipeline: run

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

64.3% Coverage
0.0% Duplication