Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test in BitcoinUtilsTest to be deterministic #2796

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Update test in BitcoinUtilsTest to be deterministic #2796

merged 1 commit into from
Oct 8, 2024

Conversation

marcos-iov
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@marcos-iov marcos-iov requested a review from a team as a code owner October 8, 2024 12:56
apancorb
apancorb approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@apancorb apancorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Vovchyk Vovchyk merged commit d19b637 into master Oct 8, 2024
11 checks passed
@Vovchyk Vovchyk deleted the make-test-deterministic branch October 8, 2024 13:23
@aeidelman aeidelman added this to the Arrowhead 6.4.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanieliov nathanieliov nathanieliov approved these changes

@apancorb apancorb apancorb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Arrowhead 6.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@marcos-iov @apancorb @nathanieliov @Vovchyk @aeidelman