Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] narrator when streaming is enabled regarding image save logic #8

Merged
merged 6 commits into from
Nov 24, 2023

Conversation

rsmets
Copy link
Owner

@rsmets rsmets commented Nov 24, 2023

No description provided.

@rsmets rsmets merged commit abeb561 into main Nov 24, 2023
@rsmets rsmets deleted the fix/imagesave branch November 24, 2023 19:04
rsmets added a commit that referenced this pull request Nov 24, 2023
* [Image] file saved along side the corresponding audio file (#6)

* [Image] file saved along side the corresponding audio file.

* [shutil] used thanks to trunk calling out security implication of the native os cp command via the script.

* [README] small update to streaming section to mention image file is not saved either.

* [README] small setup.sh wording refactor.

* [Fix] narrator when streaming is enabled regarding image save logic (#8)

* [Fix] narrator when streaming is enabled regardign image save logic

* [Fix] imagesave.

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant