Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M0019: status True/False mixed up? #121

Closed
Tracked by #132
otterdahl opened this issue Jun 17, 2021 · 7 comments
Closed
Tracked by #132

M0019: status True/False mixed up? #121

otterdahl opened this issue Jun 17, 2021 · 7 comments
Milestone

Comments

@otterdahl
Copy link
Contributor

The status of M0019 says "False: Force input" and "True: Release input" which is confusing.

Name Command Type Value Comment
status setInput boolean -False
-True
False: Force input
True: Release input
@otterdahl
Copy link
Contributor Author

I don't know how the TLC's has chosen to implement this. This needs to be checked before fixing this.

@emiltin
Copy link
Contributor

emiltin commented Jun 17, 2021

i think we should change it anyways. leaving it will just cause more confusion?

@otterdahl
Copy link
Contributor Author

otterdahl commented Jun 17, 2021

The problem is if the TLC's has implemented this according to the current text (e.g. "True: Release input"). Then fixing this will make the new SXL not backwards compatible. Previously we have chosen to avoid breaking changes in the SXL.

@emiltin
Copy link
Contributor

emiltin commented Sep 20, 2021

we should use the validator to check how equipment actually implement this

@emiltin emiltin added this to the 1.1 milestone Sep 20, 2021
@emiltin
Copy link
Contributor

emiltin commented Oct 29, 2021

our current equipment tests still run 1.0.7. we need to update the equipment (or configs) before we can run tests for M0019

@otterdahl
Copy link
Contributor Author

A similar case is M0005. It says "False: Activate", which is confusing

otterdahl added a commit that referenced this issue Dec 10, 2021
@otterdahl
Copy link
Contributor Author

Let's just fix this. Updated the draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants