fix height issues #240
Merged
fix height issues #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Rasmus! I just finished checking and fixing upper- and lowercase glyphs in all Inter styles. I wrote a script to filter for y-coordinates of extreme points that don't match the defined ascender-, descender or x-height (+-overshoot) values. Examples for glyphs (before and after fixing):
Following glyphs have been adapted to match the defined heights:
While working on those glyphs, I also smoothed some curves and fixed minor issues in the contours. Have a look and let me know what you think :) |
|
Wow! This is fantastic work Katja! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Rasmus, I started checking and fixing the alignment of lowercase-glyphs in all weights.
I wrote a small script to find critical points around the x-height und will document all glyphs that I fixed.
f.e.: the extreme point on /rho should align with overshoot:
This script also found "smallcap" glyphs, that don't align with x-height:
Is this intentional, or should I fix it too?
I also found some issues with capital glyphs: f.e. uni0370 should align with cap-height.
I could re-write the mentioned script to find not-aligning extreme points around cap-Height and fix them, too. It shouldn't take too long to adapt the script.