Update default behavior of derivative of linalg.norm and abs at x=0 #379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I also smuggled in a fix for
mygrad.arange
that normalizes its interface with that ofnumpy.arange
Now both
mygrad.linalg.norm
andmygrad.absolute
, by default, will return0
wherever their derivatives would typically not defined (and would previously have returnednan
).Both of these functions can be passed
nan_to_num=False
to enable the previous, more-rigorous, behavior.Before:
After: