Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better proptests for classification #20

Closed
V0ldek opened this issue Sep 19, 2022 · 1 comment
Closed

Better proptests for classification #20

V0ldek opened this issue Sep 19, 2022 · 1 comment
Labels
area: proptest Improvements to proptest coverage help wanted External contributions welcome type: reliability Tests, code quality
Milestone
v1.0.0

Comments

@V0ldek
Copy link
Member

V0ldek commented Sep 19, 2022

We have proptests for classifiers in tests/classifier_correctness_test.rs, but they are limited – they are explicitly coded in a way that disallows quoted sequences and escaped quotes.

It's important to test all possible paths, so these tests should be extended to also include quoted and escaped sequences. The best way to do this is unclear, so design work is also needed.
@V0ldek V0ldek added help wanted External contributions welcome type: reliability Tests, code quality labels Sep 19, 2022
@V0ldek V0ldek self-assigned this Sep 19, 2022
@V0ldek V0ldek added the acceptance: go ahead Reviewed, implementation can start label Sep 19, 2022
@V0ldek V0ldek removed their assignment Sep 20, 2022
@V0ldek V0ldek added mod: engine area: proptest Improvements to proptest coverage and removed mod: engine labels Nov 23, 2022
@V0ldek V0ldek added this to the v1.0.0 milestone Nov 23, 2022
V0ldek added a commit that referenced this issue Jul 1, 2023
@firewall2142 @V0ldek
test: generate strings in classifier tests
dffd7f4 
Improve classifier correctness tests by including quoted strings with escapes
in the generated proptest cases.

Ref: #20

Co-authored-by: Mateusz Gienieczko <mat@gienieczko.com>
@V0ldek V0ldek mentioned this issue Jul 1, 2023
Merged
3 tasks
V0ldek added a commit that referenced this issue Jul 1, 2023
@V0ldek @firewall2142
test: generate strings in classifier tests (#173)
8b636d5 
Improve classifier correctness tests by including quoted strings with escapes
in the generated proptest cases.

Ref: #20

Co-authored-by: Ashish Barnawal <ashbrnwl.2000@gmail.com>
@V0ldek
Copy link
Member Author

V0ldek commented Apr 7, 2024

#173 resolved the immediate issue of quoted sequences. I don't see any other obvious improvements here, so closing this for now.

@V0ldek V0ldek closed this as completed Apr 7, 2024
@github-project-automation github-project-automation bot moved this from Todo to Merged in Active rq development Apr 7, 2024
@V0ldek V0ldek moved this from Merged to Released in Active rq development Apr 7, 2024
@github-actions github-actions bot removed the acceptance: go ahead Reviewed, implementation can start label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: proptest Improvements to proptest coverage help wanted External contributions welcome type: reliability Tests, code quality
Projects
Active rq development
Status: Released
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@V0ldek